Is Nintendo Club a scam?

No Why would you think that????

No it is a legit program

Its not a scam. Club Nintendo is just an incentive to get people to actually buy their 3DS. They are having a problem getting people to purchase their system do to a lack of third-party developers and Nintendo dropping the ball on depending on third-party developers. 3DS games are too complex and not cost efficient to develop at the moment, so Nintendo is giving people an incentive to buy their system.

Its the same thing with their e-club thing and making Metriod and old SNES games available for download.

Scam? Nintendo Club a scam? That's foolish of you to think that!

I didn't have any experience with their services.
If you want to know if a company is legitimate or scam,you should keep in mind the following instructions
1.Use Whois lookup tool like WhoisXY.com to check the whois information.Because legitimate company properly update whois database.
2.Then check whether domain owner contact details and E-mail address is currently active or not.
3.Finally take some reviews about that company using Scamadviser.com,Webutation.net.
I am sure above the steps are very useful to check any company is legit or scam.I hope it will be very useful to you.