I have an unlocked iphone 3g if I upgrade to the new os will it take off the unlock?

That depends on the unlock that you have availed.If it is a temporary one then when you upgrade chances are there that the lock may get rolled back.To get a permanent unlock for your iPhone 3G you can approach Simpleunlocking.com and get the network unlocked.Here they unlock through remote unlocking service.