Well I'm trying to exercise to both gain muscle and lose fat.

I hear it's very hard to do and get results in a timely manner (unless you're doing steroids, which I decide not to do.) but I'm patient. I think I feel a few effects that is good on me, but I have joined a gym and would like your opinion.

I go to the gym around 5 days a week for an hourish or 1 1/2 hours. I usually start either on the treadmill or on a cardio bike for half an hour (plus a five minute cool down period on it) and usually lose about 250-300 calories on that. I then work on strength training which consist of bicep, shoulder and sometimes leg training for another half an hour.

Am I doing things right? Am I doing enough? Am I doing too much?

I would very much appreciate your opinion.